Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added black formatter to seldon_core and testing folders #980

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

axsaucedo
Copy link
Contributor

I have ran the black formatter across the python and testing folders only.

@adriangonz
Copy link
Contributor

Nice one @axsaucedo !

As part of this PR (or on subsequent ones) we could look at:

  • Configuring pre-commit to run black locally on any commit which includes *.py files. The .pre-commit-config.yaml file got added already as part of Tidy up Java #951. black has support for pre-commit out of the box, so it would involve simply adding these lines.
  • Adding a flake8 config to lint the *.py files. (we can get inspiration from black's). We can later run flake8 as part of the CI/CD pipeline.

@jklaise
Copy link
Contributor

jklaise commented Oct 22, 2019

@adriangonz good ideas! In fact I'm keen to steal the pre-commit config for alibi once it's done for seldon-core... For flake8 config we have this in alibi and CI/CD on travis already.

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants