Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test cases for load_annotations.. #941

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Add more test cases for load_annotations.. #941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/tests/test_microservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ def test_model_template_bad_params_type():
def test_load_annotations(mock_isfile):
from io import StringIO
read_data = [
('', {}),
('\n\n', {}),
('foo=bar', {'foo': 'bar'}),
('foo=bar\nx =y', {'foo': 'bar', 'x': 'y'}),
('foo=bar\nfoo=baz\n', {'foo': 'baz'}),
Expand All @@ -187,6 +189,5 @@ def test_load_annotations(mock_isfile):
('foo=\nfoo', {'foo': ''}),
]
for data, expected_annotation in read_data:
m = mock.mock_open(read_data=data)
with mock.patch('seldon_core.microservice.open', return_value=StringIO(data)):
assert microservice.load_annotations() == expected_annotation