Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update imagenet explainer to use transformer #905

Merged
merged 5 commits into from
Oct 11, 2019
Merged

Update imagenet explainer to use transformer #905

merged 5 commits into from
Oct 11, 2019

Conversation

ukclivecox
Copy link
Contributor

  • Fixes Operator bug for port assignment in multi container graphs
  • Fixes python wrapper not exposing grpc transformer services
  • Adds more debug to engine
  • Updates explainer helm chart

@seldondev seldondev requested review from arnaudvl and gsunner October 3, 2019 13:06
@ukclivecox ukclivecox mentioned this pull request Oct 3, 2019
Closed
@ryandawsonuk
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor Author

/retest

3 similar comments
@ukclivecox
Copy link
Contributor Author

/retest

@axsaucedo
Copy link
Contributor

/retest

@axsaucedo
Copy link
Contributor

/retest

@axsaucedo
Copy link
Contributor

@ryandawsonuk @cliveseldon merge is failing (due to merge conflicts), hence why tests are failing:
image

@ukclivecox
Copy link
Contributor Author

/hold

@ukclivecox
Copy link
Contributor Author

/unhold

@ukclivecox
Copy link
Contributor Author

/retest

@seldondev seldondev merged commit 68c2596 into SeldonIO:master Oct 11, 2019
@ukclivecox ukclivecox deleted the imagenet_explainer branch February 14, 2020 11:37
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref 260dd7b
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 260dd7b
  • failed to process repo SeldonIO/seldon-core refref 260dd7b
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudvl arnaudvl Awaiting requested review from arnaudvl

@gsunner gsunner Awaiting requested review from gsunner

Assignees
No one assigned
Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ukclivecox @ryandawsonuk @seldondev @axsaucedo