-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix status code handling #855
Conversation
Hi @dtaniwaki. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
How can I check the errors of the CI? |
There job seems to not have found enough resources, we'll try to retest |
/retest |
@dtaniwaki all tests pass :) although there seems to be some merge conflicts |
The conflicts were just on imports so I fixed them - you have the approved label so as soon as tests pass the PR should be automatically merged 👍 thank you for your contribution @dtaniwaki ! |
PR has been landed - thanks again for your contribution @dtaniwaki ! |
You’re welcome! |
All the errors become 400 in the current implementation.