Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous steps in seldon graph override metadata of latter steps #833

Merged
merged 7 commits into from
Sep 13, 2019

Conversation

axsaucedo
Copy link
Contributor

No description provided.

@seldondev seldondev added size/L and removed size/M labels Aug 30, 2019
@axsaucedo
Copy link
Contributor Author

@axsaucedo
Copy link
Contributor Author

@cliveseldon added unit tests, and tested locally with the same example - ready for review 👍

@axsaucedo axsaucedo requested a review from ukclivecox August 30, 2019 14:26
@axsaucedo
Copy link
Contributor Author

Fixes #829

@axsaucedo axsaucedo changed the title WIP: Added test for predictive unit bean test WIP: Previous steps in seldon graph override metadata of latter steps Aug 30, 2019
@axsaucedo axsaucedo self-assigned this Aug 30, 2019
@axsaucedo axsaucedo changed the title WIP: Previous steps in seldon graph override metadata of latter steps Previous steps in seldon graph override metadata of latter steps Sep 5, 2019
@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit e80b818 into SeldonIO:master Sep 13, 2019
@axsaucedo axsaucedo removed their assignment May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants