Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable secure argument for minio client #827

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

xaniasd
Copy link
Contributor

@xaniasd xaniasd commented Aug 28, 2019

with this change it is possible to configure the secure argument when instantiating a minio client in the following 2 ways:

  • use an S3_ENDPOINT with https scheme;
  • set environment variable USE_SSL to "false"

The default value remains True.

Resolves #825

@ukclivecox ukclivecox merged commit cf88e02 into SeldonIO:master Aug 28, 2019
@ukclivecox
Copy link
Contributor

We would need to check how this is being used by the Seldon Operator in the init container for this merged fix to be usable.

@xaniasd
Copy link
Contributor Author

xaniasd commented Aug 28, 2019

@cliveseldon I think setting S3_ENDPOINT with http:// should do the trick, I'll let you know once I've tried it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot disable secure connection to minio storage backend
3 participants