WIP: Proposed changes to ensure JSON REST Consistency (Fixes #703) #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axsaucedo
changed the title
|
@cliveseldon I've added some new tests on the funcitons added using the other tests as reference. |
|
Confirmed all relevant tests run - as soon as @cliveseldon can confirm tests run locally should be possible to land (as local tests on GRPC fail due to configuration) |
|
I can confirm that tests run locally. |
|
Perfect, thanks @jklaise |
|
Fixes #458 as well |
This was referenced Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Proposed changes to ensure JSON REST Consistency (Fixes #703)
This pull request contains the proposed changes to modify the microservice API such that for REST requests, it is ensured that the JSON requests stay intact as per the request in #703, as currently the google proto changes int representations into floats (i.e. 9 to 9.0), which modifies the original JSON in ways that then seem to affect potential proxies such like the TFServing proxy.
Once this is agreed, it would be applied across the rest of the APIs. It would also be necessary to assess that it wouldn't affect other wrappers, etc.