-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TFServing JSON Support #699
Conversation
This has been tested locally and works as expected, but when run in the kubernetes cluster the TFServing image fails to pull from the Google bucket with the following error:
|
@cliveseldon it seems that the container cannot reach the bucket. It's currently public, and it has been attempted with both the default bucket and a bucket created for this. Is there any pieces that I should be aware in regards to access for buckets? Are they only reachable from a GCloud cluster? |
The issue was the TFServing image which was outdated and causing issues. It now has been updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
predict_grpc_prev
is an old method and should be removed
This introduces the functionality required for #693 |
This pull request contains the code that adds support for raw JSON to be sent to the TF Server, so it allows for the more flexible interface that TF Serving provides. This issue addresses #694