Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

57 wrapping auto docs #68

Merged
merged 5 commits into from
Jan 25, 2018
Merged

Conversation

Maximophone
Copy link
Contributor

@Maximophone Maximophone commented Jan 24, 2018

Related to issue #57

To test:

  • build core-python-wrapper
  • use core-python-wrapper to wrap an example microservice
  • build the wrapped microservice
  • The build folder should contain a readme.md file and docker inspect <image_name> should contain a list of labels reflecting the argument that were used when wrapping

Copy link
Contributor

@ukclivecox ukclivecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/.../seldon2.0/seldon-core-fork$ docker run -v examples/models/keras_mnist/:/my_model seldonio/core-python-wrapper:0.5 /my_model MnistClassifier 0.1 seldonio
docker: Error response from daemon: create examples/models/keras_mnist/: "examples/models/keras_mnist/" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.

because I didn't specify absolute path to model - update docs to ensure people don't make this mistake.

Copy link
Contributor

@ukclivecox ukclivecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the example docs for python the final docker image could not be built

/home/.../keras_mnist/build$ make build_docker_image
./build_image.sh
invalid argument "seldonio/None:0.1" for t: invalid reference format: repository name must be lowercase
See 'docker build --help'.

@Maximophone
Copy link
Contributor Author

Fixed a bug where image name would default to None (should default to model name in lowercase)

@ukclivecox
Copy link
Contributor

should we add --rm to docker command in docs to ensure exited container is removed after wrapping , e.g.

docker run --rm -v /home/clive/work/seldon/seldon2.0/seldon-core-fork/examples/models/keras_mnist:/my_model seldonio/core-python-wrapper:0.5 /my_model MnistClassifier 0.1 seldonio

@ukclivecox ukclivecox merged commit 9465118 into SeldonIO:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants