-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
57 wrapping auto docs #68
57 wrapping auto docs #68
Conversation
…ated when wrapping and all wrapping arguments are added as labels in the dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/home/.../seldon2.0/seldon-core-fork$ docker run -v examples/models/keras_mnist/:/my_model seldonio/core-python-wrapper:0.5 /my_model MnistClassifier 0.1 seldonio
docker: Error response from daemon: create examples/models/keras_mnist/: "examples/models/keras_mnist/" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
because I didn't specify absolute path to model - update docs to ensure people don't make this mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the example docs for python the final docker image could not be built
/home/.../keras_mnist/build$ make build_docker_image
./build_image.sh
invalid argument "seldonio/None:0.1" for t: invalid reference format: repository name must be lowercase
See 'docker build --help'.
Fixed a bug where image name would default to None (should default to model name in lowercase) |
should we add --rm to docker command in docs to ensure exited container is removed after wrapping , e.g.
|
Related to issue #57
To test: