Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add server keep alive enforcement policy #6016

Merged
merged 26 commits into from
Oct 30, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Oct 30, 2024

What this PR does / why we need it:

This PR adds the relevant parameters to make client and server side keep alive work nice together. We should not allow these parameters to be set independently but in some cases they exist in different packages, so manual care is required.

This PR also tidy up some exponential backoff settings.

Which issue(s) this PR fixes:

@sakoush sakoush requested a review from lc525 as a code owner October 30, 2024 12:03
scheduler/pkg/util/grpc.go Outdated Show resolved Hide resolved
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some minor nits.

@sakoush sakoush merged commit ca025b3 into SeldonIO:v2 Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants