Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): changed the name from core v2 to Core 2 #5963

Merged
merged 10 commits into from
Oct 10, 2024
Merged

fix(docs): changed the name from core v2 to Core 2 #5963

merged 10 commits into from
Oct 10, 2024

Conversation

Rajakavitha1
Copy link
Contributor

changes the name from seldon core v2 to Seldon Core 2

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Rajakavitha1
❌ Rakavitha Kodhandapani

Rakavitha Kodhandapani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

paulb-seldon
paulb-seldon approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@paulb-seldon paulb-seldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakoush sakoush added the v2 label Oct 9, 2024
@Rajakavitha1
Update LICENSE
2b5170a 
Update after Tanu confirms from JP
@Rajakavitha1
Update license.txt
d2b0ac0 
update after Tanu confirms
@Rajakavitha1
Update license.txt
c3dbbdf 
update after Tanu confirms
@Rajakavitha1
Update license.txt
bdd7f0c 
update after Tanu confirms
@Rajakavitha1
Update license.txt
f154c4c 
update after Tanu confirms
@Rajakavitha1
Update license.txt
1d6ede3 
update after Tanu confirms
sakoush
sakoush approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. left minor comments.

operator/licenses/license.txt Outdated
@@ -531,27 +531,27 @@ Azure/go-autorest Apache License 2.0 https://github.com/Azure/go-autorest/blob
--------------------------------------------------------------------------------
AzureAD/microsoft-authentication-library-for-go MIT License https://github.com/AzureAD/microsoft-authentication-library-for-go/blob/main/LICENSE
--------------------------------------------------------------------------------
MIT License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an autogenerated file, revert change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sakoush I made no changes to those files content. Unable to revert. Please help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reversed the changes. Please recheck

scheduler/licenses/license.txt Outdated
@@ -531,27 +531,27 @@ Azure/go-autorest Apache License 2.0 https://github.com/Azure/go-autorest/blob
--------------------------------------------------------------------------------
AzureAD/microsoft-authentication-library-for-go MIT License https://github.com/AzureAD/microsoft-authentication-library-for-go/blob/main/LICENSE
--------------------------------------------------------------------------------
MIT License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an autogenerated file, please revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sakoush I made no changes to those files content. Unable to revert. Please help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reversed the changes. Please recheck

@Rajakavitha1
Update license.txt
92107e2 
reverted to the old file
@Rajakavitha1 Rajakavitha1 requested a review from sakoush October 9, 2024 10:36
sakoush
sakoush approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rajakavitha1 Rajakavitha1 merged commit 3ab43bb into v2 Oct 10, 2024
4 of 5 checks passed
@Rajakavitha1 Rajakavitha1 deleted the namechange-rajie branch October 10, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb-seldon paulb-seldon paulb-seldon approved these changes

@sakoush sakoush sakoush approved these changes

@lc525 lc525 Awaiting requested review from lc525 lc525 is a code owner

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rajakavitha1 @CLAassistant @sakoush @paulb-seldon