feat(helm-charts): allow pod spec overrides via values #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the helm charts to allow passing dictionary values that update the podSpec for: - hodometer - seldon-scheduler - seldon-envoy - seldon-dataflow-engine - seldon-modelgateway - seldon-pipelinegateway - default mlserver & triton Server CRs The podSpec value can be used to override any of the k8s pod spec configs, including: - tolerations - nodeSelector/nodeAffinity - volumes The current operator behaviour when providing list values as part of the podSpec setting is to append the elements of those lists to already existing elements. The one exception is the list under podSpec.containers, where the settings for items (containers) with the same name are *merged*.
- example defining a volume mounted in the rclone container of an inference server and pointing to a local (host) path
sakoush
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the helm charts to allow passing dictionary values that update the
podSpec for:
The podSpec value can be used to override any of the k8s pod spec configs,
including:
The current operator behaviour when providing list values as part of the podSpec
setting is to append the elements of those lists to already existing elements.
The one exception is the list under podSpec.containers, where the settings for
items (containers) with the same name are merged.
TODO
Which issue(s) this PR fixes:
Special notes for your reviewer: