-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(dataflow): Add ktlint plugin in Gradle, run formatter, and fix lint issues #5491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm,
Is linting running in the CI as well? If not please add it.
Yes I added an extra lint step here: seldon-core/.github/workflows/lint.yml Line 40 in cc5d748
Runs the worfklow here successfully: https://github.com/SeldonIO/seldon-core/actions/runs/8543232746/job/23406587633?pr=5491 |
What this PR does / why we need it:
Currently the dataflow engine has no form of linting or formatting whatsoever. This PR:
ktlint
in the Gradle wrapper through https://github.com/JLLeitschuh/ktlint-gradle and sets up minimal configuration for lintingmake lint
,make format
andmake build
make format
to fix issues automaticallyno-wild-imports
rule (https://pinterest.github.io/ktlint/1.2.1/rules/standard/#no-wildcard-imports)backing-property-naming
rule (https://pinterest.github.io/ktlint/1.2.1/rules/experimental/#property-naming)discouraged-comment-location
rule) https://pinterest.github.io/ktlint/1.2.1/rules/experimental/#discouraged-comment-locationWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: