Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fully qualified class name to be used for the model serving image. #537

Merged
merged 1 commit into from
May 4, 2019
Merged

Allow fully qualified class name to be used for the model serving image. #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/seldon_core/microservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def main():
user_class = getattr(interface_file, args.interface_name)
else:
logger.info("Importing submodule %s",parts)
interface_file = importlib.import_module(args.interface_name)
interface_file = importlib.import_module(parts[0])
user_class = getattr(interface_file, parts[1])

if args.persistence:
Expand Down
2 changes: 1 addition & 1 deletion python/tests/model-template-app2/.s2i/environment
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
MODEL_NAME=mymodule.MyModel
MODEL_NAME=mymodule.my_model.MyModel
API_TYPE=REST
SERVICE_TYPE=MODEL
PERSISTENCE=0
0 ...s/model-template-app2/mymodule/MyModel.py → .../model-template-app2/mymodule/my_model.py
View file
Open in desktop
File renamed without changes.