permission and timeout changes after trying on an openshift4 cluster #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukclivecox
approved these changes
Apr 24, 2019
agrski
added a commit
that referenced
this pull request
Dec 2, 2022
* Fix typo in pipeline help overview in CLI * Remove unnecessary duplication/nesting in default CLI arg * Use curl-style header prefixes in logs * Add blank lines after request & response headers * Add blank lines around logical operations * Add status line with infer request headers This is comparable with cURL's formatting, allowing easy comparison between the two. * Add request header line for (virtual) host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not setting the securityContext lets openshift set it automatically. Without this we were hitting:
The timeout increase is because the engine has been taking longer to start than it takes to run the probes. The liveness probe gets simplified as we don't need to check the whole graph to say that engine is live, just to say it is ready.