feat: Allow kafka consumer group id prefix configuration #5072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukclivecox
changed the title
…ipeline demo for clusterwide
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
agrski
reviewed
Aug 14, 2023
Co-authored-by: Alex Rakowski <[email protected]>
Co-authored-by: Alex Rakowski <[email protected]>
Co-authored-by: Alex Rakowski <[email protected]>
agrski
reviewed
Aug 18, 2023
| @@ -31,7 +31,7 @@ import java.nio.file.Files | |||
| object K8sCertSecretsProvider { | |||
|
|
|||
| private val kubeConfigPath: String = System.getenv("HOME") + "/.kube/config" | |||
| private val namespace = System.getenv("POD_NAMESPACE") | |||
| private val namespace = System.getenv("SELDON_POD_NAMESPACE") | |||
There was a problem hiding this comment.
💭 I'll put in a small follow-up PR to move these to use the CLI-provided value
agrski
reviewed
Aug 18, 2023
| @@ -25,6 +25,7 @@ import org.apache.kafka.streams.StreamsBuilder | |||
| import org.apache.kafka.streams.StreamsConfig | |||
| import org.apache.kafka.streams.Topology | |||
| import java.util.concurrent.CountDownLatch | |||
| import javax.xml.stream.events.Namespace | |||
agrski
reviewed
Aug 18, 2023
| @@ -72,7 +74,7 @@ class PipelineSubscriber( | |||
| suspend fun subscribe() { | |||
| logger.info("will connect to ${upstreamHost}:${upstreamPort}") | |||
| retry(grpcFailurePolicy + binaryExponentialBackoff(50..5_000L)) { | |||
| subscribePipelines() | |||
| subscribePipelines(kafkaConsumerGroupIdPrefix, namespace) | |||
There was a problem hiding this comment.
🙃 No need to pass these parameters explicitly as they've private vals above; happy to change in a follow-up PR for expediency
agrski
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows for customization of the Kafka consumer group id prefix.
Which issue(s) this PR fixes:
Fixes #5063