Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to create Seldon API testing files from any Pandas dataframe #460

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

Love-R
Copy link

@Love-R Love-R commented Mar 7, 2019

This PR adds functionality to create Seldon API testing files from any Pandas dataframe. The work has been tested with seldon-core-tester on private data.

I am not sure where this functionality belongs to, please point me a relavant folder if you want it elsewhere.

Details:

  • Ftype and dtype in the output file is based on dtype of each column of pandas dataframe. All numbers are treated as continuous and non-numbers are categoricals.
  • For continuous variables, the range for testing is based on minimum and maximum values in the file. If all values of a variable are missing, the default range is used.
  • For categorical variables, values are all unique values in the dataset.

This is a joined work with Oleg Shevelev.

@Love-R
Copy link
Author

Love-R commented Mar 25, 2019

@cliveseldon What is the procedure to get this merged?

@ukclivecox
Copy link
Contributor

This looks good. Happy to merge to master. Be good to add some docs in https://docs.seldon.io/projects/seldon-core/en/latest/workflow/api-testing.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants