Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tar to wrapper image as it is missing after move to ubi-minimal #4458

Merged
merged 1 commit into from
Nov 23, 2022
Merged

add tar to wrapper image as it is missing after move to ubi-minimal #4458

merged 1 commit into from
Nov 23, 2022

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Nov 22, 2022 •
edited
Loading

What this PR does / why we need it:

tar is not included in ubi-minimal base images - this PR re-adds it

Which issue(s) this PR fixes:

Fixes #4457

Special notes for your reviewer:

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

image

Integration passed, launching notebooks for completness.
/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/retest

1 similar comment
@RafalSkolasinski
Copy link
Contributor Author

/retest

@RafalSkolasinski
Copy link
Contributor Author

all tests passing
image

@RafalSkolasinski RafalSkolasinski mentioned this pull request Nov 23, 2022
Merged
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4458]: [Method Not Allowed]

5 similar comments
@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4458]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4458]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4458]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4458]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4458]: [Method Not Allowed]

@RafalSkolasinski RafalSkolasinski merged commit 63f1eb0 into SeldonIO:master Nov 23, 2022
adriangonz pushed a commit that referenced this pull request Nov 25, 2022
@RafalSkolasinski
add tar to wrapper image as it is missing after move to ubi-minimal (#…
425effd 
…4458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangonz adriangonz adriangonz approved these changes

Assignees
No one assigned
Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s2i issues due to missing "tar" in wrapper images
3 participants
@RafalSkolasinski @seldondev @adriangonz