Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvino ensemble adjustments #444

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Conversation

dtrawins
Copy link
Contributor

No description provided.

@ukclivecox ukclivecox self-requested a review February 12, 2019 14:02
Copy link
Contributor

@ukclivecox ukclivecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You link to this page at stop of notebook. Can you perhaps add some links/intro to OpenVINO there - as there should probably be some outbound links to OpenVINO!
  • Can you add (Optional) to heading for section on building images like it is for previous Jaeger section?
  • The last 3 kubectl commands will fail as they are pod specific names. Can you change them so it finds the pods so it always works?

Apart from that looks good!

@ukclivecox ukclivecox merged commit 4a73b85 into SeldonIO:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants