-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set allowPrivilegeEscalation to false for the service orchestrator #4427
Conversation
Hi @wumbrath. Thanks for your PR. I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
/assign @majolo |
Tests are working for me locally, not sure why it fails on github |
/retest |
@wumbrath: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
/test integration |
/test notebooks |
Looks good - will run tests |
/test integration |
/test integration |
@wumbrath: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
It seems the previous failure was a rolling upgrade test and now it's a different one so we can confirm it was a flaky test so merging now 👍 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The executor/service orchestrator container does not need privilege escalation. As a security best practice and to allow for
runnning seldon in more restricted environments this PR sets the securityContext.allowPrivilegeEscalation property to false.
Which issue(s) this PR fixes:
Fixes #4409
Special notes for your reviewer:
The program was tested solely for our own use cases, which might differ from yours.
Winfried Umbrath [email protected], Mercedes-Benz Tech Innovation GmbH, imprint