Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allowPrivilegeEscalation to false for the service orchestrator #4427

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

wumbrath
Copy link
Contributor

@wumbrath wumbrath commented Nov 4, 2022

What this PR does / why we need it:
The executor/service orchestrator container does not need privilege escalation. As a security best practice and to allow for
runnning seldon in more restricted environments this PR sets the securityContext.allowPrivilegeEscalation property to false.

Which issue(s) this PR fixes:

Fixes #4409

Special notes for your reviewer:

The program was tested solely for our own use cases, which might differ from yours.
Winfried Umbrath [email protected], Mercedes-Benz Tech Innovation GmbH, imprint

@seldondev
Copy link
Collaborator

Hi @wumbrath. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@wumbrath
Copy link
Contributor Author

wumbrath commented Nov 4, 2022

/assign @majolo

@wumbrath
Copy link
Contributor Author

wumbrath commented Nov 4, 2022

Tests are working for me locally, not sure why it fails on github

@wumbrath
Copy link
Contributor Author

wumbrath commented Nov 4, 2022

/retest

@seldondev
Copy link
Collaborator

@wumbrath: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@majolo majolo requested a review from ukclivecox November 7, 2022 17:54
@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

/test notebooks

@ukclivecox
Copy link
Contributor

Looks good - will run tests

@ukclivecox
Copy link
Contributor

Just 1 failure - will try again

Screenshot_2022-11-08_10-40-57

Screenshot_2022-11-08_10-40-40

@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

Seemed to pass integration but fail on shutdown:
Screenshot_2022-11-08_14-32-49

@ukclivecox ukclivecox requested a review from axsaucedo November 8, 2022 14:33
@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

@wumbrath: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 8378e6b link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

It seems the previous failure was a rolling upgrade test and now it's a different one so we can confirm it was a flaky test so merging now 👍
/approve

@axsaucedo axsaucedo merged commit c7ff8a3 into SeldonIO:master Nov 9, 2022
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set allowPrivilegeEscalation=false in executor
5 participants