Allow urllib3 >= 1.26.5 #4394
Allow urllib3 >= 1.26.5 #4394
Conversation
|
Hi @ysk24ok. Thanks for your PR. I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
|
Thank you for the contribution @ysk24ok - we've seen some issues in some upstream libraries (alibi explain/detect servers) if not pinning, but we'll trigger the tests and validate to ensure it all works as expected |
|
/test integration |
|
/test notebooks |
1 similar comment
|
/test notebooks |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR allows urllib3 >= 1.26.5, < 1.27.
Our serving library depends on sentry-sdk which depends on urllib3 >= 1.26.11.
If there is no specific reason to pin the version only to 1.26.5, I think it's OK to use >= 1.26.6 as well.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: