Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding intro video in docs #4337

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Embedding intro video in docs #4337

merged 3 commits into from
Sep 22, 2022

Conversation

edshee
Copy link
Contributor

@edshee edshee commented Sep 21, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@edshee
Copy link
Contributor Author

edshee commented Sep 21, 2022

Docs tests failing because the relative link won't resolve once README is copied to workflow/. I can fix with an absolute URL but that'll still fail the docs tests until it's merged to master.

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 1c80efc into master Sep 22, 2022
@edshee edshee deleted the edshee-patch-4 branch February 1, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants