Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fix for clashing zombie webhook in integration tests #4265

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Added fix for clashing zombie webhook in integration tests #4265

merged 1 commit into from
Aug 8, 2022

Conversation

axsaucedo
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes issue addressed initially via #4256

Special notes for your reviewer:

All relevant tests now passing for test_operator_updates.py:

image

RafalSkolasinski
RafalSkolasinski approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

15 similar comments
@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

agrski
agrski approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me too - nice, simple fix.

Is this the only place that call is required?

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agrski, RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RafalSkolasinski,agrski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

4 similar comments
@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [4265]: [Method Not Allowed]

@axsaucedo axsaucedo merged commit c4e51d8 into SeldonIO:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrski agrski agrski approved these changes

@RafalSkolasinski RafalSkolasinski RafalSkolasinski approved these changes

Assignees
No one assigned
Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axsaucedo @seldondev @RafalSkolasinski @agrski