Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factored out parse_args from main #4213

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

zyxue
Copy link
Contributor

@zyxue zyxue commented Jul 10, 2022

to be more modular

@zyxue zyxue changed the title factored out parse_args factored out parse_args from main Jul 10, 2022
@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo axsaucedo self-requested a review July 13, 2022 12:15
@seldondev
Copy link
Collaborator

@zyxue: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration fb4c046 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

The failing tests are only from flaky ones so we can move ahead with merge - thanks @zyxue
/approve

@axsaucedo axsaucedo merged commit 685f5cf into SeldonIO:master Jul 14, 2022
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants