Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix metadata #4207

Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix metadata #4207

merged 1 commit into from
Jul 7, 2022

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Fixes the port used for metadata and status requests

Which issue(s) this PR fixes:

Fixes: #4198

Fixes #

Special notes for your reviewer:

@ukclivecox ukclivecox requested a review from axsaucedo July 4, 2022 18:56
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test notebooks

@axsaucedo
Copy link
Contributor

Nice one - not sure how this wasn't caught before, looks good, triggered tests and will merge

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration bafc1dc link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ukclivecox ukclivecox merged commit d878a7b into SeldonIO:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem accessing triton nodes endpoints when they are part of a graph
3 participants