Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes foldering of the gpt2 minio notebook #4197

Merged
merged 5 commits into from
Jul 14, 2022

Conversation

saeid93
Copy link
Contributor

@saeid93 saeid93 commented Jun 30, 2022

What this PR does / why we need it:
As @RafalSkolasinski truly commented on my last commit there was still problems in the previous merged notebook. I made some changes to the foldering and can confirm this version works fine on my local. Please review.

Which issue(s) this PR fixes:

Fixes #4080

Special notes for your reviewer:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Hi @saeid93. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

examples/triton_gpt2/README.ipynb Outdated Show resolved Hide resolved
@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

/unapprove

@axsaucedo axsaucedo removed the approved label Jul 6, 2022
@axsaucedo
Copy link
Contributor

/hold

@axsaucedo
Copy link
Contributor

@saeid93 it seems there are some lint issues, we use formatters for the notebooks as well so running those with the same versions should fix it

@saeid93
Copy link
Contributor Author

saeid93 commented Jul 8, 2022

@axsaucedo I couldn't find the lint issue, could you please have a look and let me know where should I fix?

@axsaucedo
Copy link
Contributor

For sure, you can see the issue on the logs for the python lint job here https://github.com/SeldonIO/seldon-core/runs/7212382538?check_suite_focus=true

The way to fix it is to run the nbqa with the same version as the one we use to ensure all the notebooks are reformatted accordingly. You can find this command in the makefile, ie

To check

nbqa black \
	../ --check --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"

To modify

nbqa black \
	../ --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"

@saeid93
Copy link
Contributor Author

saeid93 commented Jul 11, 2022

thanks for the explanation, hopefully, it'll work this time.

@axsaucedo
Copy link
Contributor

NIce one @saeid93 - merging

@axsaucedo axsaucedo merged commit 99aa722 into SeldonIO:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in "Pretrained GPT2 Model Deployment Example" notebook
3 participants