-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create graph-modes.md #4144
Create graph-modes.md #4144
Conversation
Describing the SeldonIO#4092
Hi @saeid93. Thanks for your PR. I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
@saeid93 This looks great. Can you make sure you can build the docs locally and also I imagine new pages need to be added to the indexes somewhere. |
@saeid93 thank you very much for this, it's a great contribution! As you can see it seems the docs test is failing, this is because this new docs page is not linked from anywhere - could you add a link from the documentation? It could be on the reference index section, let me know if you have questions |
Thanks! Glad to help. @cliveseldon and @axsaucedo It should be fine now. |
@saeid93 it indeed looks good now - it seems we're experiencing some issues due to python-poetry/poetry#5826 (comment), we're investigating but should not be related to this so we should be ok to merge |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds the difference between single and separate pod mode in Seldon core
Which issue(s) this PR fixes:
Fixes #4092