Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix. Ensemble model. Previouse not saved data in jagear. Working with… #4139

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fix. Ensemble model. Previouse not saved data in jagear. Working with… #4139

merged 1 commit into from
Jun 7, 2022

Conversation

gawsoftpl
Copy link
Contributor

@gawsoftpl gawsoftpl commented Jun 6, 2022

Fix openvino_imagenet_ensemble.ipynb for saving times in Jaeger during predictions.

Special notes for your reviewer:
Previouse Ensemble model dont save data in Jagear and User cant see real time for graph predictions

/assign @axsaucedo

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Hi @gawsoftpl. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@axsaucedo
Copy link
Contributor

Nice one @gawsoftpl thank you for the contribution, it looks good, I am thinking we can remove the previous .json file as well as this one seems to be more relevant, however it could be done as a followup 👍

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

Docs test failure seems to be unrelated to PR - merging

@axsaucedo axsaucedo merged commit 659acac into SeldonIO:master Jun 7, 2022
@gawsoftpl gawsoftpl deleted the fix_openvino_ensemble_working_with_jagear branch June 7, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants