Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transport missing in executor #4107

Merged
merged 1 commit into from
Jun 8, 2022
Merged

fix transport missing in executor #4107

merged 1 commit into from
Jun 8, 2022

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented May 19, 2022

What this PR does / why we need it:

Ensure transport is sent to executor as is needed for Kafka processing. Also adds fixes for cifar10 demo.

Which issue(s) this PR fixes:

Fixes #4101

Special notes for your reviewer:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@ukclivecox ukclivecox requested a review from axsaucedo June 7, 2022 07:33
@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 9766f15 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

Merging as both integration tests confirmed (and fixed) via #4142

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo axsaucedo merged commit 2f3fada into SeldonIO:master Jun 8, 2022
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kafka server with seldon protocol and grpc transport sends requests to REST endpoint, not gRPC
3 participants