Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Manager Cache Fix #408

Merged
merged 3 commits into from
Feb 5, 2019
Merged

Cluster Manager Cache Fix #408

merged 3 commits into from
Feb 5, 2019

Conversation

ukclivecox
Copy link
Contributor

  • Use internal cache of SeldonDeployments only for MODIFIED updates and ignore the cache when the Kubernetes API sends an ADDED update.
    • This will fix a bug that deleting and creating a resource in quick succession can be missed as it is not removed from internal cache before the next ADDED event comes in.

This PR also:

  • Updates e2e tests to fix periodic Ambassador network errors
  • Adds some further units tests for Cluster Manager

@ukclivecox ukclivecox requested a review from gsunner January 27, 2019 08:45
@ukclivecox ukclivecox self-assigned this Jan 27, 2019
@gsunner gsunner merged commit 876c5d8 into SeldonIO:master Feb 5, 2019
@ukclivecox ukclivecox deleted the cluster_manager_cache_bug branch February 14, 2020 11:36
agrski added a commit that referenced this pull request Dec 2, 2022
@agrski
Refactor pipeline subscriber for separation of concerns (#408)
24ff144 
* Rename pipeline representation class for concision & clarity

* Refactor pipeline creation into builder method on pipelines themselves

* Create Kafka topics only when creating new pipelines

* Formatting

* Refactor pipeline creation logic with helper functions

* Remove done TODO

* Add Kafka domain params to state of pipeline

* Log topology description on pipeline start

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsunner gsunner gsunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukclivecox @gsunner