Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MLServer image to 1.0.0.rc2 #3916

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign adriangonz
You can assign the PR to them by writing /assign @adriangonz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

axsaucedo commented Feb 4, 2022

It some failures on integration tests may be flaky but rerunning to validate - notebook tests pass 👍

image

/test integration

@adriangonz
Copy link
Contributor Author

I think that the errors were actually legit ones. I've fixed the failing tests, and now testing locally first.

@adriangonz
Copy link
Contributor Author

/test integration

1 similar comment
@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

We've got green checks for the integration and (previously) for the notebooks tests! I'll cut the 1.0 release in MLServer and will update this PR 👍

image

@adriangonz adriangonz marked this pull request as ready for review February 9, 2022 09:13
@adriangonz adriangonz requested a review from axsaucedo February 9, 2022 09:13
@axsaucedo axsaucedo merged commit 811f71c into SeldonIO:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants