-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Alibi Detect Server response cloud event data is json marshalled string #3907
Conversation
7cbd3f3
to
5e9aa5c
Compare
/test integration |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one - notebook and upgrading.md looks good
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Albi Detect Server logs the detector response to a configured
replyURL
as a cloud event. The data in the cloud event at the moment is a stringified json sting, for example if the model response isthen the binary could event data is
This is because the reponse dict is converted to a json string twice using
json.dumps
method. This PR removes the extra string convertion, so that the expected binary cloud event data isNote that the detect server response remains the same and the test is updated only for the replyURL cloud event.