Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow v2 as protocol name #3906

Merged
merged 7 commits into from
Feb 10, 2022
Merged

Allow v2 as protocol name #3906

merged 7 commits into from
Feb 10, 2022

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3861

Special notes for your reviewer:

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ukclivecox
Copy link
Contributor Author

/test notebooks

@ukclivecox
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor

/test integration

2 similar comments
@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox
Copy link
Contributor Author

/test notebooks

@axsaucedo
Copy link
Contributor

Nice seems all tests passing - will do a final pass and we can merge 👍

image

@axsaucedo
Copy link
Contributor

Tested locally - looks good
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 97791d1 into SeldonIO:master Feb 10, 2022
@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3906]: [Method Not Allowed]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo left review comments

Assignees
No one assigned
Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for named "v2" protocol to CRD manifests
3 participants
@ukclivecox @axsaucedo @seldondev