Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade confluent-kafka-go to v1.8.2 #3870

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

stephen37
Copy link
Contributor

What this PR does / why we need it: We can't use PEM strings for SSL if we don't have that version of confluent-kafka-go

Which issue(s) this PR fixes:

Fixes #3866

Special notes for your reviewer:

@seldondev
Copy link
Collaborator

Hi @stephen37. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign adriangonz
You can assign the PR to them by writing /assign @adriangonz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stephen37
Copy link
Contributor Author

@cliveseldon Shall we merge that one so that I can add the support for PEM strings? 🙏

@ukclivecox
Copy link
Contributor

@stephen37 Sounds good.

@ukclivecox ukclivecox merged commit d72dc01 into SeldonIO:master Jan 21, 2022
@stephen37 stephen37 deleted the upgrade_kafka_executor branch January 21, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade executor confluent-kafka-go version to v1.8.2
3 participants