Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump upper constrains of MLflow server dependencies #3863

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Bump upper constrains of MLflow server dependencies #3863

merged 5 commits into from
Jan 19, 2022

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:

Update version constrains from the requests package to ensure compatibility with MLflow's own dependencies.

Which issue(s) this PR fixes:

Fixes #3846

Special notes for your reviewer:

@adriangonz adriangonz requested a review from axsaucedo January 17, 2022 13:33
@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@seldondev seldondev added size/L and removed size/XS labels Jan 17, 2022
@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz
Copy link
Contributor Author

/test integration

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@seldondev seldondev added size/S and removed size/L labels Jan 18, 2022
@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

Rebuild pre-packaged servers if there's a change to both the pre-pack…
e356230 
…aged folder and / or the base Python folder
@seldondev seldondev added size/M and removed size/S labels Jan 18, 2022
@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

@adriangonz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 961ae18 link /test notebooks
integration e356230 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit f03bf27 into SeldonIO:master Jan 19, 2022
@adriangonz adriangonz mentioned this pull request Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammedi-haroune mohammedi-haroune mohammedi-haroune left review comments

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees
No one assigned
Labels
approved size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with deploying a model from MLFlow
4 participants
@adriangonz @seldondev @axsaucedo @mohammedi-haroune