-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seldon add ssl #3813
Seldon add ssl #3813
Conversation
Alongside the extra functionality added in this PR, it'd be good to have documentation explaining at least what SSL options are available (e.g. that key/cert files can be provided but not directly the equivalent strings) |
To avoid having to write the same piece of code twice, I refactored the code. I cannot get the test to do what I want though, if I don't set a `broker` then it just hangs and if I set a broker then it throws an error with ``` %7|1640872656.856|BROKERFAIL|rdkafka#producer-1| [thrd:ssl://broker:9092/bootstrap]: ssl://broker:9092/bootstrap: failed: err: Local: Host resolution failure: (errno: Bad address) %7|1640872656.856|STATE|rdkafka#producer-1| [thrd:ssl://broker:9092/bootstrap]: ssl://broker:9092/bootstrap: Broker changed state CONNECT -> DOWN %7|1640872656.856|BROADCAST|rdkafka#producer-1| [thrd:ssl://broker:9092/bootstrap]: Broadcasting state change %7|1640872656.856|BUFQ|rdkafka#producer-1| [thrd:ssl://broker:9092/bootstrap]: ssl://broker:9092/bootstrap: Purging bufq with 0 buffers %7|1640872656.856|BUFQ|rdkafka#producer-1| [thrd:ssl://broker:9092/bootstrap]: ssl://broker:9092/bootstrap: Purging bufq with 0 buffers %7|1640872656.856|BUFQ|rdkafka#producer-1| [thrd:ssl://broker:9092/bootstrap]: ssl://broker:9092/bootstrap: Updating 0 buffers on connection reset ```
executor/logger/worker_test.go
Outdated
// myOAuthConfig := "scope=myscope principal=gotest" | ||
// p, err := kafka.NewProducer(&kafka.ConfigMap{ | ||
// "security.protocol": "SASL_PLAINTEXT", | ||
// "sasl.mechanisms": "OAUTHBEARER", | ||
// "sasl.oauthbearer.config": myOAuthConfig, | ||
// }) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That part is only here if you wanna run a debug test and check what the producer is creating.
Based on this section in the I've also been completely unable to find anything useful related to I suppose that leaves two options:
The first option feels like overkill for what amounts to parameter-passing unit tests We may want to look at integration tests for the variation combinations of options for all this in the future. |
I've created #3830 to track integration tests for Kafka |
Co-authored-by: Alex Rakowski <[email protected]>
Co-authored-by: Alex Rakowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this! Although I've not tested against a live Kafka setup, LGTM and should have no impact if SSL is not in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agrski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add capabilities to use SSL when using Kafka when logging payloads or using Kafka server type.
Which issue(s) this PR fixes:
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: