-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model_name when chaining requests #3805
Conversation
/test integration |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mentioned that there is a model version as well possibly, but I dont see how is that handled in what you have done so far.
Another point, do we have also model_name
and model_version
in REST payload? if not how are we handling then this case? in other words are we going to suffer from the same issue in REST?
if model_name: | ||
endpoint = f"{root_endpoint}/v2/models/{model_name}/infer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mentioned a version that we need to handle in the PR description, where is that handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, missed this comment.
Mmmh not sure what you mean. Was this on the PR description? Could you point out where?
The failed integration tests seem to be known flaky ones,
So this PR should be OK to go ahead 👍 |
/test integration |
1 similar comment
/test integration |
/retest |
cb33320
to
211597f
Compare
/test integration |
2 similar comments
/test integration |
/test integration |
@adriangonz: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
It seems that the failed integration tests are known flaky ones unrelated to the changes on this PR, so I think it should be good to go:
|
Hey @sakoush , Apologies, just noticed your review comment now. Not sure what you mean about the model version. Could you point out where was that mentioned? When using REST, the model name and version are part of the endpoint, so not required to be on the payload as well. This is only required for gRPC, as per the V2 Protocol spec. |
Ok thanks for clarification |
What this PR does / why we need it:
model_name
is updated when chaining requests across a model graph.model_name
is present on the first request (i.e. so that it's not necessary that the user sends it on the initial request to the graph).Which issue(s) this PR fixes:
Fixes #3792
Special notes for your reviewer:
Does this PR introduce a user-facing change?: