release script code #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
agrski
added a commit
that referenced
this pull request
Dec 2, 2022
* Add Protobuf contract for scheduler proxy * Add termination handling for proxy * Move scheduler proxy under scheduler package * Add proxy server for scheduler The gRPC endpoints have not been implemented, but a server can be created and started. * Update proxy to use new gRPC server * Move proxy Proto contract under scheduler contracts * Break long commands in Makefile over multiple lines * Add proxy Proto contract * Fix bugs in proxy and remove extra, wrapping interface as superfluous * Regenerate Go files for proxy Proto contract * Send model events to proxy scheduler via channel * Add types for proxy scheduler * Add channel for server-scheduler in proxy * Add minimal proxy scheduler implementation * Add build & run Make targets for proxy scheduler * Add scheduler to proxy app * Remove unnecessary locking around channel writes Channels are already thread-safe constructs. * Add log message on termination * Reorder proxy server methods for legibility * Add CLI args & config for log-level * Pass proxy log-level through Make target * Rename New method for clarity * Add agent-server to proxy scheduler * Simplify binary output exclusion in gitignore * Use agent-server in proxy application * Add basic IPy notebook for proxy scheduler * Refactor proxy defaults to config file * Add args/flags for remaining config values Also, rename fields in embedded structs to avoid collisions. * Refactor flag parsing to config file * Add logging for config on proxy startup * Reorder proxy startup to separate creation from usage This adheres to the pattern of given-when-then, i.e. create your objects, configure them, then use them. * Use pointer for Protobuf message This is required due to the Protobuf types using locks internally. They should only ever be passed by reference, it seems. * Add logging for scheduling errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.