Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak script to generate MLflow environment tarball #3794

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Tweak script to generate MLflow environment tarball #3794

merged 3 commits into from
Dec 8, 2021

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:
Tweak the script which generates the MLflow demo artifact so that it also creates an environment.tar.gz tarball.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski
Copy link
Contributor

/test models

@seldondev seldondev added size/S and removed size/XS labels Dec 7, 2021
@adriangonz
Copy link
Contributor Author

/retest

@RafalSkolasinski
Copy link
Contributor

/test models

@adriangonz
Copy link
Contributor Author

/retest

@adriangonz
Copy link
Contributor Author

/test models

@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented Dec 8, 2021 •
edited
Loading

Seems to work fine

rclone ls gs://seldon-models/v1.12.0-dev/ | grep wine
      350 mlflow/elasticnet_wine/MLmodel
      143 mlflow/elasticnet_wine/conda.yaml
234734119 mlflow/elasticnet_wine/environment.tar.gz
      185 mlflow/elasticnet_wine/metadata.yaml

@RafalSkolasinski
Copy link
Contributor

image

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 147b5b0 into SeldonIO:master Dec 8, 2021
seldondev pushed a commit that referenced this pull request Dec 8, 2021
@axsaucedo
Tweak script to generate MLflow environment tarball (#3794)
2b61f99 
* Tweak pipeline to generate MLflow artifact

* Add MLServer to the tarball

* Fix relative paths
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
Tweak script to generate MLflow environment tarball (SeldonIO#3794)
aae0f3c 
* Tweak pipeline to generate MLflow artifact

* Add MLServer to the tarball

* Fix relative paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalSkolasinski RafalSkolasinski RafalSkolasinski approved these changes

Assignees
No one assigned
Labels
approved size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriangonz @RafalSkolasinski @seldondev