Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use lowercase seldon-puid in batch processor #3791

Merged
merged 1 commit into from
Dec 7, 2021
Merged

use lowercase seldon-puid in batch processor #3791

merged 1 commit into from
Dec 7, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

fixes grpc with batch processor

@axsaucedo
Copy link
Contributor

/test integration

majolo
majolo approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@majolo majolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice lgtm

testing/scripts/test_batch_processor.py

logging.info("Sending first batch (grpc): mini-batch size=1")

start_multithreaded_batch_worker(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function call is getting really ugly imo, way too many arguments and not clear what each one is doing from here. In Go I would suggest we could refactor and pass a struct BatchWorkerOpts, but not sure what the most idiomatic Python approach is. (also this is future work not for this PR)

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: majolo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski
Copy link
Contributor Author

@axsaucedo I did run batch processor integration tests locally so we do not need to wait for CI in principle

@axsaucedo axsaucedo merged commit 03ed062 into SeldonIO:master Dec 7, 2021
@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration cf09430 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

seldondev pushed a commit that referenced this pull request Dec 8, 2021
@RafalSkolasinski @axsaucedo
use lowercase seldon-puid in batch processor (#3791)
83f468c
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
@RafalSkolasinski
use lowercase seldon-puid in batch processor (SeldonIO#3791)
c458f08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majolo majolo majolo approved these changes

Assignees
No one assigned
Labels
approved size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RafalSkolasinski @axsaucedo @seldondev @majolo