Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build adserver dockerimage using poetry-defined environment #3783

Merged
merged 11 commits into from
Dec 8, 2021
Merged

build adserver dockerimage using poetry-defined environment #3783

merged 11 commits into from
Dec 8, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Dec 5, 2021 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3784
Fixes #3660

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski RafalSkolasinski marked this pull request as draft December 5, 2021 14:30
@RafalSkolasinski
Copy link
Contributor Author

/test integratiopn

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/retest

@RafalSkolasinski
Copy link
Contributor Author

/test this

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review December 8, 2021 10:55
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo axsaucedo merged commit 1bd637a into SeldonIO:master Dec 8, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski RafalSkolasinski mentioned this pull request Dec 8, 2021
Closed
@RafalSkolasinski RafalSkolasinski mentioned this pull request Dec 8, 2021
Closed
seldondev pushed a commit that referenced this pull request Dec 8, 2021
@RafalSkolasinski @axsaucedo
build adserver dockerimage using poetry-defined environment (#3783)
a374534 
* build adserver dockerimage using poetry-defined environment

* add unti test to pipeline

* fix typo

* fix linter

* tests fix?

* add tenacity

* add stuff for cv imports in test image

* .

* run only adserver tests

* fix image in feedback/metrics-server notebook

* fix release.py
@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 56ca263 link /test notebooks
integration 56ca263 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@RafalSkolasinski
Copy link
Contributor Author

Just for records:

Integration failures on:

  • TestRollingHttp.test_rolling_update5[ambas]
  • TestRollingHttp.test_rolling_update10[ambas]
  • test_label_update[1.7.0]
  • test_label_update[1.10.0]
  • TestADServer.test_alibi_detect_cifar10_rclone

The rclone test is fixed in followup PR.

Notebooks failures on:

  • TestNotebooks.test_upgrade
  • TestNotebooks.test_server_examples

stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
@RafalSkolasinski
build adserver dockerimage using poetry-defined environment (SeldonIO…
0fd9149 
…#3783)

* build adserver dockerimage using poetry-defined environment

* add unti test to pipeline

* fix typo

* fix linter

* tests fix?

* add tenacity

* add stuff for cv imports in test image

* .

* run only adserver tests

* fix image in feedback/metrics-server notebook

* fix release.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo left review comments

Assignees
No one assigned
Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stateful Model Feedback Metrics Server uses wrong image Move adserver to use Poetry
3 participants
@RafalSkolasinski @axsaucedo @seldondev