Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove explainer_examples.ipynb from notebook test #3778

Merged
merged 1 commit into from
Dec 1, 2021
Merged

remove explainer_examples.ipynb from notebook test #3778

merged 1 commit into from
Dec 1, 2021

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Dec 1, 2021

What this PR does / why we need it:

This PR remove explainer_examples.ipynb from notebook tests as we rely now on integration tests in test_alibi_explain.py
and test_alibi_explain_v2.py

Which issue(s) this PR fixes:

Fixes #3777

Special notes for your reviewer:

This PR doesnt actually remove the file explainer_examples.ipynb, just the reference to it.

Does this PR introduce a user-facing change?:

…ion tests test_alibi_explain.py

and test_alibi_explain_v2.py
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski RafalSkolasinski merged commit ce9a284 into SeldonIO:master Dec 1, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
…ion tests test_alibi_explain.py (SeldonIO#3778)

and test_alibi_explain_v2.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove explainer_examples notebook
3 participants