-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: decompress gzip paloyads before logging them #3746
executor: decompress gzip paloyads before logging them #3746
Conversation
/test integration |
/test notebooks |
/test integration |
/test notebooks |
Integration failure:
Notebook failures:
|
/test integration |
/test notebooks |
1 similar comment
/test notebooks |
NIce one - looks good, rerunning notebook tests |
Now integration test failures on:
which would indicate that integration failures are caused by flakiness. |
Notebook failure on same tests now. I believe |
/test notebooks |
JUst had a look, I can see that Integration tests failing seem to be only v2 ones which are known to be flaky, but I would have another look just in case. /test integration |
@RafalSkolasinski: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Seems integration tests are indeed failing on just flaky tests, but notebook tests do indeed seem to consistently fail on explainer tests, would be worth running locally to validate |
@axsaucedo we confirmed with @sakoush that the explainer notebook failure is related to the use of recent changes in explainers when using kfserving protocol. @sakoush will look into fixing the notebook. Looks like we can go ahead and merge this one! |
Perfecto - thanks @RafalSkolasinski /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* executor: decompress gzip paloyads before logging them * extend kfserving sample to include logger * refactor * further refactor
What this PR does / why we need it:
This is temporary fix until we can close #3690.
It is to ensure that CloudEvents send to the logging endpoint are not compressed.
Which issue(s) this PR fixes:
Fixes #3749
Special notes for your reviewer:
Does this PR introduce a user-facing change?: