Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: decompress gzip paloyads before logging them #3746

Merged
merged 4 commits into from
Nov 19, 2021
Merged

executor: decompress gzip paloyads before logging them #3746

merged 4 commits into from
Nov 19, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Nov 17, 2021

What this PR does / why we need it:

This is temporary fix until we can close #3690.
It is to ensure that CloudEvents send to the logging endpoint are not compressed.

Which issue(s) this PR fixes:

Fixes #3749

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@seldondev seldondev added size/L and removed size/M labels Nov 18, 2021
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

Integration failure:

  • TestPrepack.test_mlflow_v2

Notebook failures:

  • TestNotebooks.test_explainer_examples
  • TestNotebooks.test_upgrade

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

1 similar comment
@axsaucedo
Copy link
Contributor

/test notebooks

@axsaucedo
Copy link
Contributor

NIce one - looks good, rerunning notebook tests

@RafalSkolasinski
Copy link
Contributor Author

Now integration test failures on:

  • TestPrepack.test_mlflow_v2
  • TestPrepack.test_xgboost_v2

which would indicate that integration failures are caused by flakiness.

@RafalSkolasinski
Copy link
Contributor Author

Notebook failure on same tests now. I believe TestNotebooks.test_upgrade was broken but I am not sure about explainer examples one. Will run again and if still failure will verify locally.

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@axsaucedo
Copy link
Contributor

JUst had a look, TestNotebooks.test_upgrade is expected to fail as the -dev helm charts were pushed which would affect that test specifically, so can be ignored given that integration tests upgrade works.

I can see that TestNotebooks.test_explainer_examples is indeed failing again, so it may actually be an issue so would suggest running locally.

Integration tests failing seem to be only v2 ones which are known to be flaky, but I would have another look just in case.

/test integration

@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 0eafdc9 link /test notebooks
integration 0eafdc9 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

Seems integration tests are indeed failing on just flaky tests, but notebook tests do indeed seem to consistently fail on explainer tests, would be worth running locally to validate

@RafalSkolasinski
Copy link
Contributor Author

@axsaucedo we confirmed with @sakoush that the explainer notebook failure is related to the use of recent changes in explainers when using kfserving protocol. @sakoush will look into fixing the notebook.

Looks like we can go ahead and merge this one!

@axsaucedo
Copy link
Contributor

Perfecto - thanks @RafalSkolasinski

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 2e57a07 into SeldonIO:master Nov 19, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
* executor: decompress gzip paloyads before logging them

* extend kfserving sample to include logger

* refactor

* further refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants