Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart annotations cont, manager container security context #3741

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

mwm5945
Copy link
Contributor

@mwm5945 mwm5945 commented Nov 15, 2021

What this PR does / why we need it:
Fixes @agrski 's comment for the correct indentation on the manager deployment annotations, adds a container security context to the same deployment.

Which issue(s) this PR fixes:

Fixes #3698

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add container security context to controller manager

@seldondev
Copy link
Collaborator

Hi @mwm5945. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sachinvarghese
You can assign the PR to them by writing /assign @sachinvarghese in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mwm5945
Copy link
Contributor Author

mwm5945 commented Nov 15, 2021

@agrski This fixes your comment in the last annotations PR. Also @cliveseldon @axsaucedo, this adds a container security context (different from a pod security context) to allow the container to utilize those fields (such as readOnlyRootFileSystem)

@ukclivecox ukclivecox merged commit bce0b30 into SeldonIO:master Nov 15, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
…3741)

* fix nindent for controller dep

* add container security context to manager deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Controller Manager to have configurable container security context
3 participants