-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add endpoint to match python status endpoint #3731
Conversation
Hi @mwm5945. Thanks for your PR. I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@axsaucedo or @cliveseldon any thoughts on this? seems simple enough to have a consistent |
@mwm5945 Seems good. |
cool! i've been having some issues getting kafka libs to compile on apple M1 silicon, do you have any tips? (i could always mount it in a docker container) |
0bedd07
to
532d1a4
Compare
Most of us don't use Mac. Maybe open a separate issue for this with the error? |
/test integration |
@mwm5945: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Adds a matching endpoint to the executor such that the status endpoint is consistent across single node graphs without the executor, and ones with the executor.
Which issue(s) this PR fixes:
Fixes #3705
Special notes for your reviewer:
Does this PR introduce a user-facing change?: