Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add endpoint to match python status endpoint #3731

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

mwm5945
Copy link
Contributor

@mwm5945 mwm5945 commented Nov 11, 2021

What this PR does / why we need it:
Adds a matching endpoint to the executor such that the status endpoint is consistent across single node graphs without the executor, and ones with the executor.

Which issue(s) this PR fixes:

Fixes #3705

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add status path to match the python microservice path

@seldondev
Copy link
Collaborator

Hi @mwm5945. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mwm5945
Copy link
Contributor Author

mwm5945 commented Nov 12, 2021

@axsaucedo or @cliveseldon any thoughts on this? seems simple enough to have a consistent status endpoint :)

@ukclivecox
Copy link
Contributor

ukclivecox commented Nov 13, 2021

@mwm5945 Seems good.

@mwm5945
Copy link
Contributor Author

mwm5945 commented Nov 13, 2021

cool! i've been having some issues getting kafka libs to compile on apple M1 silicon, do you have any tips? (i could always mount it in a docker container)

@mwm5945 mwm5945 marked this pull request as ready for review November 13, 2021 15:07
@ukclivecox
Copy link
Contributor

cool! i've been having some issues getting kafka libs to compile on apple M1 silicon, do you have any tips? (i could always mount it in a docker container)

Most of us don't use Mac. Maybe open a separate issue for this with the error?

@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

@mwm5945: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 532d1a4 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ukclivecox ukclivecox merged commit 1db1557 into SeldonIO:master Nov 15, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python/Executor path mis-match
4 participants