Chart annotations

[mwm5945]

What this PR does / why we need it: Adds configurable annotations to the CRDs and Manager deployment templates.

Which issue(s) this PR fixes:

Fixes #3699

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add annotation fields to helm template for CRD and deployment

[seldondev]

Hi @mwm5945. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[ukclivecox]

@mwm5945 We will probably need to change https://github.com/SeldonIO/seldon-core/blob/master/operator/helm/split_resources.py rather than the template files directly as they are generated by this script from the kustomize.

[mwm5945]

/assign @cliveseldon

@cliveseldon updated :)

[seldondev]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ukclivecox]

/test integration

[ukclivecox]

/test notebooks

[ukclivecox]

/test notebooks

[ukclivecox]

/test notebooks

[seldondev]

@mwm5945: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
notebooks	24c85ee	link	/test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

[ukclivecox]

Thanks @mwm5945 !

[agrski]

❓ Couple of days late, but shouldn't this be an indent 8 spaces not 4?

[mwm5945]

yep--i'll fix in another pr. Good catch!