-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch processor enhancemenst through raw data parameter #3718
Batch processor enhancemenst through raw data parameter #3718
Conversation
Example on echo model for input:
run as
will give as output
(the |
/test integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one - looks good overall, added couple of comments, would be good to also add documenattion as part of the PR in the batching section to cover the constraints in which this would work as weell
/test integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce one - comments are quite minor and some are more suggestions so we can resolve if not relevant, and we can merge once tests pass
/approve
/retest |
/test integration |
/retest |
/test integration |
Integration failure on: |
The executor failure
looks odd but if anything this is unrelated to this PR. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add predict raw functionality to batch processor * linter * fix 1 * refactor extracting mini-batch from raw payloads into separate function * remove all_equal function * improve logging of exceptions * further improve logging * final improvements + documentation * add typing; change back to indexes * add link to issue
What this PR does / why we need it:
These solves family of issues gathered together under #3702
Which issue(s) this PR fixes:
Closes #3702
and therefore as well
Closes #2657
Closes #3409
Closes #3681
Closes #3408
Special notes for your reviewer:
Does this PR introduce a user-facing change?: