Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rbac in example yaml to v1 api #3676

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Change rbac in example yaml to v1 api #3676

merged 1 commit into from
Oct 19, 2021

Conversation

westford14
Copy link
Contributor

What this PR does / why we need it:

This PR resolves issue #3403 across the repo on top of within the helm charts explicitly mentioned in the issue. All instances of rbac.authorization.k8s.io/v1beta1 have been updated to rbac.authorization.k8s.io/v1. All helm charts / manifests have been deployed successfully to a kind v0.11.1 cluster.

Which issue(s) this PR fixes:
Fixes #3403

Special notes for your reviewer:

Does this PR introduce a user-facing change?: Yes

* seldon-core helm charts no longer have deprecation warnings for rbac.authorization.k8s.io/v1beta1

@seldondev
Copy link
Collaborator

Hi @westford14. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sachinvarghese
You can assign the PR to them by writing /assign @sachinvarghese in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@westford14
Copy link
Contributor Author

/assign @SachinVarghese

@ukclivecox ukclivecox changed the title Issue 3403 Change rbac in example yaml to v1 api Oct 19, 2021
@ukclivecox ukclivecox merged commit 7f89dca into SeldonIO:master Oct 19, 2021
@ukclivecox
Copy link
Contributor

@westford14 Thanks!

stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade seldon-core-analytics helm charts
4 participants