Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in admission webhook for tensorflow protocol #3656

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

agrski
Copy link
Contributor

@agrski agrski commented Oct 11, 2021

What this PR does / why we need it:
Fix typo in SeldonDeployment admission webhook error message - tensorflow is misspelled.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix typo in error message for SeldonDeployment admission webhook.

@agrski
Copy link
Contributor Author

agrski commented Oct 11, 2021

/retest

@agrski
Copy link
Contributor Author

agrski commented Oct 11, 2021

/test docs-lint

@axsaucedo
Copy link
Contributor

Thanks for the contribution @agrski - the docs test seems to be flagging a broken URL so that can be addressed on a separate pr, merging
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit a1d3d22 into SeldonIO:master Oct 11, 2021
@agrski agrski deleted the fix-admission-webhook-typo branch October 11, 2021 16:40
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants