Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snyk security scans #3645

Merged
merged 15 commits into from
Oct 14, 2021
Merged

Conversation

axsaucedo
Copy link
Contributor

@axsaucedo axsaucedo commented Oct 6, 2021

Includes scans for python/, operator/ and executor/

For reference secrets in public repositores as of today are only accessible on PRs created from top level repo and not from forked repos.

https://stackoverflow.com/questions/58737785/github-actions-empty-env-secrets

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo added the security Pull requests that address a security vulnerability label Oct 14, 2021
@axsaucedo
Copy link
Contributor Author

Merging as now the PR will only run with tag from same repo, and manually triggered

@axsaucedo axsaucedo merged commit d334c95 into SeldonIO:master Oct 14, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
* Added snyk security scans

* updated workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Pull requests that address a security vulnerability size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants